# [PATCH] HP-UX traditionally has no sys/select.h 5 messages from 2008-01-24 to 2008-01-24. Participants: Robert Schiele, Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/11721 ## Robert Schiele, 2008-01-24 17:53 Subject: [PATCH] HP-UX traditionally has no sys/select.h Message-ID: <20080124175300.GI30676@schiele.dyndns.org> URL: https://gitlist.dev/e/20080124175300.GI30676%40schiele.dyndns.org ``` The select stuff is already in sys/time.h on traditional HP-UX systems thus we should not include sys/select.h there because older releases don't have it. --- git-compat-util.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/git-compat-util.h b/git-compat-util.h index b6ef544..77de915 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -68,7 +68,9 @@ #include #include #include +#ifndef __hpux #include +#endif #include #include #include -- 1.5.2.4 ``` ## Johannes Schindelin, 2008-01-24 18:03 Subject: Re: [PATCH] HP-UX traditionally has no sys/select.h Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0801241758130.5731%40racer.site In-Reply-To: <20080124175300.GI30676@schiele.dyndns.org> ``` Hi, On Thu, 24 Jan 2008, Robert Schiele wrote: > The select stuff is already in sys/time.h on traditional HP-UX > systems thus we should not include sys/select.h there because older > releases don't have it. Thank you for your patch. > diff --git a/git-compat-util.h b/git-compat-util.h > index b6ef544..77de915 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -68,7 +68,9 @@ > #include > #include > #include > +#ifndef __hpux > #include > +#endif > #include > #include > #include We try to avoid using constructs like this. Rather, we have a section in the Makefile which sets things like NO_IPV6=YesPlease, OLD_ICONV=UnfortunatelyYes, etc. Later in the Makefile, dependent on this Makefile variable, symbols are defined. In the source code, we check for these symbols. It is not only a matter of being able to reuse the same symbol for another platform/setup, it is also a nice way of documentation. In your case, I suggest NO_SYS_SELECT_H=UnfortunatelyYes. Thanks, Dscho ``` ## Robert Schiele, 2008-01-24 18:36 Subject: Re: [PATCH] HP-UX traditionally has no sys/select.h Message-ID: <20080124183645.GL30676@schiele.dyndns.org> URL: https://gitlist.dev/e/20080124183645.GL30676%40schiele.dyndns.org In-Reply-To: ``` On Thu, Jan 24, 2008 at 06:03:14PM +0000, Johannes Schindelin wrote: > We try to avoid using constructs like this. Rather, we have a section in > the Makefile which sets things like NO_IPV6=YesPlease, > OLD_ICONV=UnfortunatelyYes, etc. > > Later in the Makefile, dependent on this Makefile variable, symbols > are defined. In the source code, we check for these symbols. > > It is not only a matter of being able to reuse the same symbol for another > platform/setup, it is also a nice way of documentation. > > In your case, I suggest NO_SYS_SELECT_H=UnfortunatelyYes. Ok, implemented it that way now and also made HP-UX support in Makefile in a separate patch. Robert -- Robert Schiele Dipl.-Wirtsch.informatiker mailto:rschiele@gmail.com "Quidquid latine dictum sit, altum sonatur." ``` ## Junio C Hamano, 2008-01-24 19:11 Subject: Re: [PATCH] HP-UX traditionally has no sys/select.h Message-ID: <7vd4rravin.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vd4rravin.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20080124175300.GI30676@schiele.dyndns.org> ``` Robert Schiele writes: > The select stuff is already in sys/time.h on traditional HP-UX > systems thus we should not include sys/select.h there because older > releases don't have it. > --- > git-compat-util.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/git-compat-util.h b/git-compat-util.h > index b6ef544..77de915 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -68,7 +68,9 @@ > #include > #include > #include > +#ifndef __hpux > #include > +#endif > #include > #include > #include > -- > 1.5.2.4 We had a thread on this issue mid December. Does this help? >From 72a41cae180ad57c6f2daa0af9b96e284386dc1b Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 18 Dec 2007 01:52:07 -0800 Subject: [PATCH] Do not include on pre- POSIX.1-2001 systems For previous version of SUS, select(2) would have been declared in , which is already included. POSIX.1-2001 moved the declaration to , so check _POSIX_VERSION with 200112L and skip inclusion of if it is not the case. Signed-off-by: Junio C Hamano --- git-compat-util.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/git-compat-util.h b/git-compat-util.h index b6ef544..fb3b969 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -68,7 +68,9 @@ #include #include #include +#if _POSIX_VERSION >= 200112L #include +#endif #include #include #include -- 1.5.4.rc4.23.gcab31 ``` ## Robert Schiele, 2008-01-24 19:39 Subject: Re: [PATCH] HP-UX traditionally has no sys/select.h Message-ID: <20080124193942.GM30676@schiele.dyndns.org> URL: https://gitlist.dev/e/20080124193942.GM30676%40schiele.dyndns.org In-Reply-To: <7vd4rravin.fsf@gitster.siamese.dyndns.org> ``` On Thu, Jan 24, 2008 at 11:11:44AM -0800, Junio C Hamano wrote: > We had a thread on this issue mid December. > Does this help? Yes, checking for the _POSIX_VERSION is also a working approach. Robert -- Robert Schiele Dipl.-Wirtsch.informatiker mailto:rschiele@gmail.com "Quidquid latine dictum sit, altum sonatur." ```