threads / patch / 11697

patchMake t5710 more strict when creating nested repos

Subject: [PATCH] Make t5710 more strict when creating nested repos

## tl;dr

One message between Jan 21, 2008 and Jan 21, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alex Riesen· Jan 21, 2008, 20:53 UTC · lore

The test 'creating too deep nesting' can fail even when cloning the repos, but is not its main purpose (it has to prepare nested repos and ensure the last one is invalid). So split the test into the creation and invalidity checking parts.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

Noticed try to figure out why the test breaks on cygwin with the recent in-core-index branch. Didn't manage that, though.

 t/t5710-info-alternate.sh |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
Show changes to t/t5710-info-alternate.sh +8 −4
diff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh
index 699df6e..1908dc8 100755
--- a/t/t5710-info-alternate.sh
+++ b/t/t5710-info-alternate.sh
@@ -53,14 +53,18 @@ git prune'
 
 cd "$base_dir"
 
-test_expect_failure 'creating too deep nesting' \
+test_expect_success 'creating too deep nesting' \
 'git clone -l -s C D &&
 git clone -l -s D E &&
 git clone -l -s E F &&
 git clone -l -s F G &&
-git clone -l -s G H &&
-cd H &&
-test_valid_repo'
+git clone -l -s G H'
+
+test_expect_success 'invalidity of deepest repository' \
+'cd H && {
+	test_valid_repo
+	test $? -ne 0
+}'
 
 cd "$base_dir"
 
-- 
1.5.4.rc3.49.gd0cc3

← back to recent threads