# [PATCH] fast-import: Don't use a maybe-clobbered errno value

1 messages from 2008-01-18 to 2008-01-18. Participants: Jim Meyering.
Thread: https://gitlist.dev/t/11670

## Jim Meyering, 2008-01-18 18:35

Subject: [PATCH] fast-import: Don't use a maybe-clobbered errno value
Message-ID: <8763xrgewq.fsf@rho.meyering.net>
URL: https://gitlist.dev/e/8763xrgewq.fsf%40rho.meyering.net

```

Without this change, each diagnostic could use an errno value
clobbered by the close or unlink in rollback_lock_file.

Signed-off-by: Jim Meyering <meyering@redhat.com>
---
 fast-import.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/fast-import.c b/fast-import.c
index 5e89eef..45b4edf 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -1541,9 +1541,10 @@ static void dump_marks(void)

 	f = fdopen(mark_fd, "w");
 	if (!f) {
+		int saved_errno = errno;
 		rollback_lock_file(&mark_lock);
 		failure |= error("Unable to write marks file %s: %s",
-			mark_file, strerror(errno));
+			mark_file, strerror(saved_errno));
 		return;
 	}

@@ -1556,16 +1557,18 @@ static void dump_marks(void)

 	dump_marks_helper(f, 0, marks);
 	if (ferror(f) || fclose(f)) {
+		int saved_errno = errno;
 		rollback_lock_file(&mark_lock);
 		failure |= error("Unable to write marks file %s: %s",
-			mark_file, strerror(errno));
+			mark_file, strerror(saved_errno));
 		return;
 	}

 	if (commit_lock_file(&mark_lock)) {
+		int saved_errno = errno;
 		rollback_lock_file(&mark_lock);
 		failure |= error("Unable to commit marks file %s: %s",
-			mark_file, strerror(errno));
+			mark_file, strerror(saved_errno));
 		return;
 	}
 }
--
1.5.4.rc3.31.g669237

```