# [PATCH] Squelch bogus progress output from git-rebase--interactive

2 messages from 2008-01-15 to 2008-01-15. Participants: Junio C Hamano, Johannes Schindelin.
Thread: https://gitlist.dev/t/11625

## Junio C Hamano, 2008-01-15 04:04

Subject: [PATCH] Squelch bogus progress output from git-rebase--interactive
Message-ID: <7v3aszivjk.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v3aszivjk.fsf%40gitster.siamese.dyndns.org

```
The command repeats "Rebasing (1/1)" many times even when
there is only one task remaining, because mark_action_done() is
called to skip comment and empty lines in the TODO file.

This should fix it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-rebase--interactive.sh |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index acdcc54..402ff37 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -73,14 +73,19 @@ comment_for_reflog () {
 	esac
 }
 
+last_count=
 mark_action_done () {
 	sed -e 1q < "$TODO" >> "$DONE"
 	sed -e 1d < "$TODO" >> "$TODO".new
 	mv -f "$TODO".new "$TODO"
 	count=$(($(grep -ve '^$' -e '^#' < "$DONE" | wc -l)))
 	total=$(($count+$(grep -ve '^$' -e '^#' < "$TODO" | wc -l)))
-	printf "Rebasing (%d/%d)\r" $count $total
-	test -z "$VERBOSE" || echo
+	if test "$last_count" != "$count"
+	then
+		last_count=$count
+		printf "Rebasing (%d/%d)\r" $count $total
+		test -z "$VERBOSE" || echo
+	fi
 }
 
 make_patch () {
-- 
1.5.4.rc3.10.g471a

```

## Johannes Schindelin, 2008-01-15 11:22

Subject: Re: [PATCH] Squelch bogus progress output from git-rebase--interactive
Message-ID: <alpine.DEB.1.00.0801151122450.5289@eeepc-johanness>
URL: https://gitlist.dev/e/alpine.DEB.1.00.0801151122450.5289%40eeepc-johanness
In-Reply-To: <7v3aszivjk.fsf@gitster.siamese.dyndns.org>

```
Hi,

On Mon, 14 Jan 2008, Junio C Hamano wrote:

> The command repeats "Rebasing (1/1)" many times even when
> there is only one task remaining, because mark_action_done() is
> called to skip comment and empty lines in the TODO file.
> 
> This should fix it.

Yes, it should.

Thanks,
Dscho

```