# [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault 3 messages from 2008-01-05 to 2008-01-05. Participants: Brandon Casey, Junio C Hamano. Thread: https://gitlist.dev/t/11478 ## Brandon Casey, 2008-01-05 01:11 Subject: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault Message-ID: <477ED949.1030909@nrlssc.navy.mil> URL: https://gitlist.dev/e/477ED949.1030909%40nrlssc.navy.mil ``` Signed-off-by: Brandon Casey --- builtin-reflog.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-reflog.c b/builtin-reflog.c index f422693..5e54989 100644 --- a/builtin-reflog.c +++ b/builtin-reflog.c @@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix) int recno; if (!spec) { - status |= error("Not a reflog: %s", ref); + status |= error("Not a reflog: %s", argv[i]); continue; } -- 1.5.4.rc2.1119.g6fdf-dirty ``` ## Junio C Hamano, 2008-01-05 01:22 Subject: Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault Message-ID: <7vzlvlf4n9.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vzlvlf4n9.fsf%40gitster.siamese.dyndns.org In-Reply-To: <477ED949.1030909@nrlssc.navy.mil> ``` Brandon Casey writes: > Signed-off-by: Brandon Casey > --- > builtin-reflog.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/builtin-reflog.c b/builtin-reflog.c > index f422693..5e54989 100644 > --- a/builtin-reflog.c > +++ b/builtin-reflog.c > @@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix) > int recno; > > if (!spec) { > - status |= error("Not a reflog: %s", ref); > + status |= error("Not a reflog: %s", argv[i]); > continue; > } Bad Brandon! Looking at 'next' while everybody is asked to work on finding and fixing bugs on 'master' while -rc freeze. Just kidding. Thanks, the code is obviously correct, and will queue. I am not so surprised to see bugs in relatively new code that is only in 'next', especially this one that no Porcelains already use. ``` ## Brandon Casey, 2008-01-05 01:35 Subject: Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault Message-ID: <477EDEFB.7020909@nrlssc.navy.mil> URL: https://gitlist.dev/e/477EDEFB.7020909%40nrlssc.navy.mil In-Reply-To: <7vzlvlf4n9.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano wrote: > Bad Brandon! Looking at 'next' while everybody is asked to work > on finding and fixing bugs on 'master' while -rc freeze. No more, I promise. :) -brandon ```