threads / patch / 11339

patchgit-filter-branch.sh: more portable tr usage: use \012, not \n.

Subject: [PATCH] git-filter-branch.sh: more portable tr usage: use \012, not \n.

## tl;dr

One message between Dec 18, 2007 and Dec 18, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jim Meyering· Dec 18, 2007, 10:03 UTC · lore

I hesitate to suggest this, since GNU tr has accepted \n for 15 years, but there are supposedly a few crufty vendor-supplied versions of tr still in use. Also, all of the other uses of tr-with-newline in git use \012.

Signed-off-by: Jim Meyering <meyering@redhat.com>
---
 git-filter-branch.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-filter-branch.sh +1 −2
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 3bb2f67..ee9e1b3 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -290,7 +290,7 @@ while read commit parents; do
 		eval "$filter_tree" < /dev/null ||
 			die "tree filter failed: $filter_tree"

-		git diff-index -r $commit | cut -f 2- | tr '\n' '\000' | \
+		git diff-index -r $commit | cut -f 2- | tr '\012' '\000' | \
 			xargs -0 git update-index --add --replace --remove
 		git ls-files -z --others | \
 			xargs -0 git update-index --add --replace --remove
--
1.5.4.rc0.53.gdfcd

← back to recent threads