threads / patch / 11277

patchgit-svn: unlink internal index files after operations

Subject: [PATCH] git-svn: unlink internal index files after operations

## tl;dr

3 messages between Dec 13, 2007 and Dec 14, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Eric Wong· Dec 13, 2007, 16:27 UTC · lore

Being git, we can generate these very quickly on the fly as needed, so there's no point in wasting space for these things for large projects.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-svn.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to git-svn.perl +3 −0

diff --git a/git-svn.perl b/git-svn.perl
index 54d7844..fde39e2 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -396,6 +396,7 @@ sub cmd_set_tree {
 	}
 	$gs->set_tree($_) foreach @revs;
 	print "Done committing ",scalar @revs," revisions to SVN\n";
+	unlink $gs->{index};
 }
 
 sub cmd_dcommit {
@@ -514,6 +515,7 @@ sub cmd_dcommit {
 			$last_rev = $cmt_rev;
 		}
 	}
+	unlink $gs->{index};
 }
 
 sub cmd_find_rev {
@@ -1374,6 +1376,7 @@ sub fetch_all {
 
 	($base, $head) = parse_revision_argument($base, $head);
 	$ra->gs_fetch_loop_common($base, $head, \@gs, \@globs);
+	unlink $_->{index} foreach @gs;
 }
 
 sub read_all_remotes {

-- 
Eric Wong

Karl Hasselström· Dec 13, 2007, 20:27 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: unlink internal index files after operations

On 2007-12-13 08:27:34 -0800, Eric Wong wrote:

> Being git, we can generate these very quickly on the fly as needed,
> so there's no point in wasting space for these things for large
> projects.

Excellent!

For existing repos, I assume the correct thing to do is to just blast all the existing index files manually?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

Eric Wong· Dec 14, 2007, 08:29 UTC · re: Karl Hasselström · lore

Re: [PATCH] git-svn: unlink internal index files after operations

Karl Hasselström <kha@treskal.com> wrote:

Show 10 quoted lines

> On 2007-12-13 08:27:34 -0800, Eric Wong wrote:
> 
> > Being git, we can generate these very quickly on the fly as needed,
> > so there's no point in wasting space for these things for large
> > projects.
> 
> Excellent!
> 
> For existing repos, I assume the correct thing to do is to just blast
> all the existing index files manually?

Yes. index files inside $GIT_DIR/svn have always been safely deletable (except while a git-svn is actually running :).

I'll probably work on an automated full migration strategy at some point (handling rev_db => rev_map, mainly) when I have time.

-- 
Eric Wong