threads / discuss / 11251

exit with error for "git remote update"

Subject: exit with error for "git remote update"

## tl;dr

One message between Dec 12, 2007 and Dec 12, 2007.

replies: 0people: 1as markdown or json

Robert Schiele· Dec 12, 2007, 06:17 UTC · lore
Hi,

When I call "git remote update" without an additional parameter it always returns with an error, even when all fetch commands processed without a problem.

This is because of the exit(1) in the following code:
elsif ($ARGV[0] eq 'update') {
        if (@ARGV <= 1) {
                update_remote("default");
                exit(1);
        }
        for ($i = 1; $i < @ARGV; $i++) {
                update_remote($ARGV[$i]);
        }
}

Shouldn't this exit(1) be an exit(0) instead or just rewrite this part of the code as

elsif ($ARGV[0] eq 'update') {
        if (@ARGV <= 1) {
                update_remote("default");
        } else {
                for ($i = 1; $i < @ARGV; $i++) {
                        update_remote($ARGV[$i]);
                }
        }
}
Robert
-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."

← back to recent threads