threads / patch / 11215

patchRemove .git/branches from the .git template.

Subject: [PATCH] Remove .git/branches from the .git template.

## tl;dr

3 messages between Dec 9, 2007 and Dec 10, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Kristian Høgsberg· Dec 9, 2007, 18:38 UTC · lore

The code in git to read the info in .git/branches is still there, but nothing ever writes to this, so lets stop creating it.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
---

As far as I can see this should be safe, but I admit to never really knowing what .git/branches was originally used for - tracking remote branches or something? In any case, we only ever read from this dir so the only left in git to deal with this seems to be for compatibilty with older repos.

Kristian

 templates/branches-- |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
 delete mode 100644 templates/branches--

Show changes to templates/branches-- +0 −1

diff --git a/templates/branches-- b/templates/branches--
deleted file mode 100644
index fae8870..0000000
--- a/templates/branches--
+++ /dev/null
@@ -1 +0,0 @@
-: this is just to ensure the directory exists.

-- 
1.5.3.4

Junio C Hamano· Dec 9, 2007, 18:30 UTC · re: Kristian Høgsberg · lore

Re: [PATCH] Remove .git/branches from the .git template.

Kristian Høgsberg <krh@bitplanet.net> writes:

Show 11 quoted lines

> The code in git to read the info in .git/branches is still there,
> but nothing ever writes to this, so lets stop creating it.
>
> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> ---
>
> As far as I can see this should be safe, but I admit to never really
> knowing what .git/branches was originally used for - tracking remote
> branches or something?  In any case, we only ever read from this dir
> so the only left in git to deal with this seems to be for compatibilty
> with older repos.

This was done purely so that Cogito would not barf on a repository initialized with "git init" even if it did not bother creating necessary leading directories when it writes its rough equivalent to .git/remotes/ information. I do not recall if Cogito had such a problem anymore, but I think it can safely go when Cogito is effectively dead.

Kristian Høgsberg· Dec 10, 2007, 04:34 UTC · re: Junio C Hamano · lore

Re: [PATCH] Remove .git/branches from the .git template.

On Sun, Dec 09, 2007 at 10:30:55AM -0800, Junio C Hamano wrote:

Show 19 quoted lines

> Kristian Høgsberg <krh@bitplanet.net> writes:
> 
> > The code in git to read the info in .git/branches is still there,
> > but nothing ever writes to this, so lets stop creating it.
> >
> > Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> > ---
> >
> > As far as I can see this should be safe, but I admit to never really
> > knowing what .git/branches was originally used for - tracking remote
> > branches or something?  In any case, we only ever read from this dir
> > so the only left in git to deal with this seems to be for compatibilty
> > with older repos.
> 
> This was done purely so that Cogito would not barf on a repository
> initialized with "git init" even if it did not bother creating necessary
> leading directories when it writes its rough equivalent to .git/remotes/
> information.  I do not recall if Cogito had such a problem anymore, but
> I think it can safely go when Cogito is effectively dead.

OK, I don't know where cogito is in that respect, I thought maybe we had just forgotten we still created that directory. Should we just try to apply the patch to find out how it might interact with cogito?

Kristian