# [PATCH] sha1_file.c;prepare_packed_git_one() - fix DIR leak

2 messages from 2005-07-06 to 2005-07-06. Participants: Junio C Hamano.
Thread: https://gitlist.dev/t/1114

## Junio C Hamano, 2005-07-06 06:52

Subject: [PATCH] sha1_file.c;prepare_packed_git_one() - fix DIR leak
Message-ID: <7voe9gxw7y.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7voe9gxw7y.fsf%40assigned-by-dhcp.cox.net

```
The function calls opendir() without a matching closedir().

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 sha1_file.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

7a47797264a0be7955f3422a6e79e3311ab2775f
diff --git a/sha1_file.c b/sha1_file.c
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -463,6 +463,7 @@ static void prepare_packed_git_one(char 
 		p->next = packed_git;
 		packed_git = p;
 	}
+	closedir(dir);
 }
 
 void prepare_packed_git(void)

```

## Junio C Hamano, 2005-07-06 08:11

Subject: [PATCH] clone-pack.c:write_one_ref() - Create leading directories.
Message-ID: <7vfyusxsjb.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vfyusxsjb.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <7voe9gxw7y.fsf@assigned-by-dhcp.cox.net>

```
The function write_one_ref() is passed the list of refs received
from the other end, which was obtained by directory traversal
under $GIT_DIR/refs; this can contain paths other than what
git-init-db prepares and would fail to clone when there is
such.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 cache.h      |    2 ++
 clone-pack.c |    5 ++++-
 sha1_file.c  |   19 +++++++++++++++++++
 3 files changed, 25 insertions(+), 1 deletions(-)

dfad9e5e585c1c9e1eaf599878f040f7ae519b18
diff --git a/cache.h b/cache.h
--- a/cache.h
+++ b/cache.h
@@ -161,6 +161,8 @@ extern void rollback_index_file(struct c
 extern char *git_path(const char *fmt, ...);
 extern char *sha1_file_name(const unsigned char *sha1);
 
+int safe_create_leading_directories(char *path);
+
 /* Read and unpack a sha1 file into memory, write memory to a sha1 file */
 extern void * map_sha1_file(const unsigned char *sha1, unsigned long *size);
 extern int unpack_sha1_header(z_stream *stream, void *map, unsigned long mapsize, void *buffer, unsigned long size);
diff --git a/clone-pack.c b/clone-pack.c
--- a/clone-pack.c
+++ b/clone-pack.c
@@ -68,9 +68,12 @@ static int is_master(struct ref *ref)
 static void write_one_ref(struct ref *ref)
 {
 	char *path = git_path(ref->name);
-	int fd = open(path, O_CREAT | O_EXCL | O_WRONLY, 0666);
+	int fd;
 	char *hex;
 
+	if (safe_create_leading_directories(path))
+		die("unable to create leading directory for %s", ref->name);
+	fd = open(path, O_CREAT | O_EXCL | O_WRONLY, 0666);
 	if (fd < 0)
 		die("unable to create ref %s", ref->name);
 	hex = sha1_to_hex(ref->sha1);
diff --git a/sha1_file.c b/sha1_file.c
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -130,6 +130,25 @@ char *git_path(const char *fmt, ...)
 	return ret;
 }
 
+int safe_create_leading_directories(char *path)
+{
+	char *pos = path;
+
+	while (pos) {
+		pos = strchr(pos, '/');
+		if (!pos)
+			break;
+		*pos = 0;
+		if (mkdir(path, 0777) < 0)
+			if (errno != EEXIST) {
+				*pos = '/';
+				return -1;
+			}
+		*pos++ = '/';
+	}
+	return 0;
+}
+
 int get_sha1(const char *str, unsigned char *sha1)
 {
 	static const char *prefix[] = {

```