# [PATCH] git-show: only chdir(prefix) when prefix is not NULL, and check for success 1 messages from 2007-12-02 to 2007-12-02. Participants: Johannes Schindelin. Thread: https://gitlist.dev/t/11083 ## Johannes Schindelin, 2007-12-02 01:42 Subject: [PATCH] git-show: only chdir(prefix) when prefix is not NULL, and check for success Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0712020141530.27959%40racer.site ``` We blindly called "chdir(prefix);" and did not even check if it succeeded. Found by valgrind. Signed-off-by: Johannes Schindelin --- builtin-log.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/builtin-log.c b/builtin-log.c index 21f3b0f..0f38579 100644 --- a/builtin-log.c +++ b/builtin-log.c @@ -285,7 +285,8 @@ int cmd_show(int argc, const char **argv, const char *prefix) struct object_array_entry *objects; int i, count, ret = 0; - chdir(prefix); + if (prefix && chdir(prefix)) + die ("Could not change directory to '%s'", prefix); git_config(git_log_config); init_revisions(&rev, prefix); -- 1.5.3.6.2112.ge2263 ```