threads / patch / 11066

patchMake git homepage (main page) use valid HTML

Subject: [PATCH (homepage)] Make git homepage (main page) use valid HTML

## tl;dr

4 messages between Nov 30, 2007 and Nov 30, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Jakub Narebski· Nov 30, 2007, 10:59 UTC · lore
Checked by W3C Markup Validation Service:
  http://validator.w3.org

Most of those changes makes git homepage use valid XML / SGML; the errors were incorrect ordering of closing tags, wrong closing tags, spurious closing tags.

HTML declares that <p> element cannot contain other block elements (at least not interspersed with text); correcting this also fixed layout (in Mozilla), where part of paragraph after <pre> element was not indented.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Resent.
I hope that it would make through anti-SPAM filters...
 index.html |   23 +++++++++++------------
 1 files changed, 11 insertions(+), 12 deletions(-)
Show changes to index.html +11 −12
diff --git a/index.html b/index.html
index 01726f6..29fa0b1 100644
--- a/index.html
+++ b/index.html
@@ -88,7 +88,8 @@ Junio C Hamano.</p>
 
 <h2 id="about">About Git</h2>
 
-<div style="float: right"><table class="releases">
+<div style="float: right">
+<table class="releases">
 	<tr><th><a href="course/index.html">Git Crash Courses</a></th></tr>
 	<tr><td align="center">
 	<a 
href="http://www.kernel.org/pub/software/scm/git/docs/tutorial.html">Git 
for everyone</a>
@@ -98,8 +99,9 @@ Junio C Hamano.</p>
 	<br /><a href="course/stgit.html">Maintaining external patches</a>
 	<br /><a href="course/svn.html">Git for SVN users</a>
 	<br /><em>More to come soon...</em>
-	</tr></td>
-</table></div>
+	</td></tr>
+</table>
+</div>
 
 <p>Git is distributed version control system focused on
 speed, effectivity and real-world usability on large projects.
@@ -173,7 +175,7 @@ and are either porting an existing toolset to use 
the Git tools,
 or reimplementing the concepts internally,
 to benefit from the performance improvements.
 This includes e.g.
-<a href="http://wiki.darcs.net/DarcsWiki/DarcsGit">Darcs-git</a>.</li>
+<a href="http://wiki.darcs.net/DarcsWiki/DarcsGit">Darcs-git</a>.</p>
 
 
 <hr />
@@ -223,7 +225,7 @@ You can also use one of many <a 
href="http://www.kernel.org/mirrors/">kernel.org
 <tr class="odd">
 <td rowspan="3">Debs</td>
 <td>Stable</td>
-<td><a 
href="http://www.backports.org/debian/pool/main/g/git-core/">http://www.backports.org/debian/pool/main/g/git-core/</a></dd></td>
+<td><a 
href="http://www.backports.org/debian/pool/main/g/git-core/">http://www.backports.org/debian/pool/main/g/git-core/</a></td>
 </tr>
 <tr>
 <td>Testing</td>
@@ -233,7 +235,6 @@ You can also use one of many <a 
href="http://www.kernel.org/mirrors/">kernel.org
 <td>Unstable</td>
 <td><a 
href="http://packages.debian.org/unstable/devel/git-core">http://packages.debian.org/unstable/devel/git-core</a></td>
 </tr>
-</td>
 
 </table>
 
@@ -247,16 +248,14 @@ You can also use one of many <a 
href="http://www.kernel.org/mirrors/">kernel.org
 <h3>Git by git</h3>
 
 <p>If you already have Git installed, you can get the latest
-development version via Git itself:
+development version via Git itself:</p>
 <pre>git clone git://git.kernel.org/pub/scm/git/git.git</pre>
-</p>
 
 <p>If you have problems connecting (Git uses port 9418),
-you can try to access the repository over the HTTP protocol:
+you can try to access the repository over the HTTP protocol:</p>
 <pre>git clone http://www.kernel.org/pub/scm/git/git.git</pre>
-(this method is considerably slower but works even behind
-firewalls and such).
-</p>
+<p>(this method is considerably slower but works even behind
+firewalls and such).</p>
 
 <p>You can also always browse the current contents
 of the git repository on web using the kernel.org
-- 
1.5.3.6
Jonas Fonseca· Nov 30, 2007, 11:42 UTC · re: Jakub Narebski · lore

Re: [PATCH (homepage)] Make git homepage (main page) use valid HTML

On Nov 30, 2007 11:59 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> I hope that it would make through anti-SPAM filters...

I've applied this and your previous patch that added links to Windows binaries. Should be mirrored one pasky pushes his update button.

Show 10 quoted lines
> @@ -233,7 +235,6 @@ You can also use one of many <a
> href="http://www.kernel.org/mirrors/">kernel.org
>  <td>Unstable</td>
>  <td><a
> href="http://packages.debian.org/unstable/devel/git-core">http://packages.debian.org/unstable/devel/git-core</a></td>
>  </tr>
> -</td>
>
>  </table>
>

BTW, the patch contained multiple wrapping problems. Don't know if it is from your side or my broken use of GMail.

-- 
Jonas Fonseca
Jakub Narebski· Nov 30, 2007, 11:55 UTC · re: Jonas Fonseca · lore

Re: [PATCH (homepage)] Make git homepage (main page) use valid HTML

Jonas Fonseca wrote:
> 
> I've applied this and your previous patch that added links to Windows
> binaries. Should be mirrored one pasky pushes his update button.
> BTW, the patch contained multiple wrapping problems. Don't know if
> it is from your side or my broken use of GMail.

I'm sorry, this was my mistake (forgot to turn off word wrapping when sending this patch). But as you have applied it, I don't need to resend, do I?

-- 
Jakub Narebski
Poland
Jonas Fonseca· Nov 30, 2007, 12:04 UTC · re: Jakub Narebski · lore

Re: [PATCH (homepage)] Make git homepage (main page) use valid HTML

On Nov 30, 2007 12:55 PM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 7 quoted lines
> Jonas Fonseca wrote:
> > BTW, the patch contained multiple wrapping problems. Don't know if
> > it is from your side or my broken use of GMail.
>
> I'm sorry, this was my mistake (forgot to turn off word wrapping when
> sending this patch). But as you have applied it, I don't need to
> resend, do I?
No.
-- 
Jonas Fonseca

← back to recent threads