# [PATCH 2/2] Change to gitk to make it use --topo-order rather than --merge-order

1 messages from 2005-07-02 to 2005-07-02. Participants: Jon Seymour.
Thread: https://gitlist.dev/t/1088

## Jon Seymour, 2005-07-02 06:09

Subject: [PATCH 2/2] Change to gitk to make it use --topo-order rather than --merge-order
Message-ID: <20050702060938.13030.qmail@blackcubes.dyndns.org>
URL: https://gitlist.dev/e/20050702060938.13030.qmail%40blackcubes.dyndns.org

```

This patch make gitk use --topo-order rather than --merge-order.

There is no actual advantage in doing this as the git-rev-list 
execution times are dwarfed by tcl/tk overheads so the 3-4 time
git-rev-list speedup is effectively invisible. Still, it
does demonstrate the use of the --topo-order flag.

One advantage of this patch would be to allow gitk to be used
in environments that don't have the ssl bignum library available
for some reason.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
This patch assumes that git has been patched to include support
for --topo-order.

Here's a chance to test merging a gitk patch from git back into
gitk :-)
---

 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

4deb99b73fd6fc8e4995b55e9e23988c8766f509
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -37,7 +37,7 @@ proc getcommits {rargs} {
 	set parsed_args $rargs
     }
     if [catch {
-	set commfd [open "|git-rev-list --header --merge-order $parsed_args" r]
+	set commfd [open "|git-rev-list --header --topo-order $parsed_args" r]
     } err] {
 	puts stderr "Error executing git-rev-list: $err"
 	exit 1
------------

```