[PATCH] print warning/error/fatal messages in one shot

Nicolas Pitre· Nov 9, 2007, 19:33 UTC · lore

Not doing so is likely to create a messed up display when sent over the sideband protocol.

Signed-off-by: Nicolas Pitre <nico@cam.org>
---

Show changes to usage.c +3 −3

diff --git a/usage.c b/usage.c
index f5e652c..a5fc4ec 100644
--- a/usage.c
+++ b/usage.c
@@ -7,9 +7,9 @@
 
 static void report(const char *prefix, const char *err, va_list params)
 {
-	fputs(prefix, stderr);
-	vfprintf(stderr, err, params);
-	fputs("\n", stderr);
+	char msg[256];
+	vsnprintf(msg, sizeof(msg), err, params);
+	fprintf(stderr, "%s%s\n", prefix, msg);
 }
 
 static NORETURN void usage_builtin(const char *err)

patchprint warning/error/fatal messages in one shot