threads / patch / 10740

patchgit-cvsimport: fix handling of user name when it is not set in CVSROOT

Subject: [PATCH] git-cvsimport: fix handling of user name when it is not set in CVSROOT

## tl;dr

One message between Nov 8, 2007 and Nov 8, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Gordon Hopper· Nov 8, 2007, 20:15 UTC · lore

The cvs programs do not default to "anonymous" as the user name, but use the currently logged in user. This patch more closely matches the cvs behavior.

Signed-off-by: Gordon Hopper <g.hopper@computer.org>
---
 git-cvsimport.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to git-cvsimport.perl +2 −1
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index e4bc2b5..efa6a0c 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -223,7 +223,8 @@ sub conn {
 			}
 		}

-		$user="anonymous" unless defined $user;
+		# if username is not explicit in CVSROOT, then use current user, as cvs would
+		$user=(getlogin() || $ENV{'LOGNAME'} || $ENV{'USER'} ||
"anonymous") unless $user;
 		my $rr2 = "-";
 		unless ($port) {
 			$rr2 = ":pserver:$user\@$serv:$repo";
-- 
1.5.3.5

← back to recent threads