# [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header 5 messages from 2007-11-08 to 2008-01-22. Participants: Gerrit Pape, Junio C Hamano, Andreas Ericsson, Benoit Sigoure. Thread: https://gitlist.dev/t/10727 ## Gerrit Pape, 2007-11-08 09:48 Subject: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header Message-ID: <20071108094809.22151.qmail@97f06c2e73713e.315fe32.mid.smarden.org> URL: https://gitlist.dev/e/20071108094809.22151.qmail%4097f06c2e73713e.315fe32.mid.smarden.org ``` $committer is already extracted from the latest existing rev, so add the corresponding From: line to the email header. Signed-off-by: Gerrit Pape --- contrib/hooks/post-receive-email | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 3904c18..c73f2d5 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -189,6 +189,7 @@ generate_email_header() # --- Email (all stdout will be the email) # Generate header cat <<-EOF + From: $committer To: $recipients Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe X-Git-Refname: $refname -- 1.5.3.5 ``` ## Junio C Hamano, 2007-11-08 09:55 Subject: Re: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header Message-ID: <7vode52hag.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vode52hag.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20071108094809.22151.qmail@97f06c2e73713e.315fe32.mid.smarden.org> ``` Gerrit Pape writes: > $committer is already extracted from the latest existing rev, so add the > corresponding From: line to the email header. You may fight this out with Andy if you want to, but I think I'd side with the existing behaviour. commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b Author: Andy Parkins Date: Fri Sep 28 15:24:26 2007 +0100 post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used Using the name of the committer of the revision at the tip of the updated ref is not sensible. That information is available in the email itself should it be wanted, and by supplying a "From", we were effectively hiding the person who performed the push - which is useful information in itself. Signed-off-by: Andy Parkins Signed-off-by: Junio C Hamano diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 1f88099..cbbd02f 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -177,7 +177,6 @@ generate_email_header() # --- Email (all stdout will be the email) # Generate header cat <<-EOF - From: $committer To: $recipients Subject: ${EMAILPREFIX}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe X-Git-Refname: $refname ``` ## Andreas Ericsson, 2007-11-08 10:35 Subject: Re: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header Message-ID: <4732E657.7020202@op5.se> URL: https://gitlist.dev/e/4732E657.7020202%40op5.se In-Reply-To: <7vode52hag.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano wrote: > Gerrit Pape writes: > >> $committer is already extracted from the latest existing rev, so add the >> corresponding From: line to the email header. > > You may fight this out with Andy if you want to, but I think I'd > side with the existing behaviour. > I'm with Andy here, for the reasons stated below. > commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b > Author: Andy Parkins > Date: Fri Sep 28 15:24:26 2007 +0100 > > post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used > > Using the name of the committer of the revision at the tip of the > updated ref is not sensible. That information is available in the email > itself should it be wanted, and by supplying a "From", we were > effectively hiding the person who performed the push - which is useful > information in itself. > -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 ``` ## Gerrit Pape, 2007-11-08 12:11 Subject: [PATCH] contrib/hooks/post-receive-email: remove cruft, $committer is not used Message-ID: <20071108121157.9749.qmail@db594f724cf2e2.315fe32.mid.smarden.org> URL: https://gitlist.dev/e/20071108121157.9749.qmail%40db594f724cf2e2.315fe32.mid.smarden.org In-Reply-To: <7vode52hag.fsf@gitster.siamese.dyndns.org> ``` Signed-off-by: Gerrit Pape --- contrib/hooks/post-receive-email | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 3904c18..7511ea0 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -156,10 +156,6 @@ generate_email() fi # Email parameters - # The committer will be obtained from the latest existing rev; so - # for a deletion it will be the oldrev, for the others, then newrev - committer=$(git show --pretty=full -s $rev | sed -ne "s/^Commit: //p" | - sed -ne 's/\(.*\) /dev/null) -- 1.5.3.5 ``` ## Benoit Sigoure, 2008-01-22 14:12 Subject: Re: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header Message-ID: URL: https://gitlist.dev/e/CA518F22-C0E4-4C2E-A86C-6E8CB1776FAE%40lrde.epita.fr In-Reply-To: <7vode52hag.fsf@gitster.siamese.dyndns.org> ``` On Nov 8, 2007, at 10:55 AM, Junio C Hamano wrote: > Gerrit Pape writes: > >> $committer is already extracted from the latest existing rev, so >> add the >> corresponding From: line to the email header. > > You may fight this out with Andy if you want to, but I think I'd > side with the existing behaviour. > > commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b > Author: Andy Parkins > Date: Fri Sep 28 15:24:26 2007 +0100 > > post-receive-hook: Remove the From field from the generated > email header so that the pusher's name is used > > Using the name of the committer of the revision at the tip of the > updated ref is not sensible. That information is available in > the email > itself should it be wanted, and by supplying a "From", we were > effectively hiding the person who performed the push - which is > useful > information in itself. > > Signed-off-by: Andy Parkins > Signed-off-by: Junio C Hamano Hi guys, the problem with this change is that when one uses Gitosis all the commits are pushed with the `git' user so emails always appear to come from git@fqdn. I guess it would be worth to add an option to retain the old behavior (where $committer was extracted from the last commit pushed and used in the `From' field), don't you think? -- Benoit Sigoure aka Tsuna EPITA Research and Development Laboratory ```