threads / patch / 1054

patch, 3 partsRemove unnecessary sort from t6001 testcase

Subject: [PATCH 3/3] Remove unnecessary sort from t6001 testcase

## tl;dr

One message between Jun 30, 2005 and Jun 30, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jon Seymour· Jun 30, 2005, 02:41 UTC · lore
This patch removes an unnecessary sort from the t6001 testcase.

Sorts were previously necessary when testing non --merge-order cases because the output order wasn't entirely deterministic unless commit date was fixed.

However, commit dates are now fixed, so the need for a sort has disappeared. So the sort has been removed.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
 t/t6001-rev-list-merge-order.sh |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
4a4c2a209c0121314aa444c1c5e361ad43f1848a
Show changes to t/t6001-rev-list-merge-order.sh +8 −8
diff --git a/t/t6001-rev-list-merge-order.sh b/t/t6001-rev-list-merge-order.sh
--- a/t/t6001-rev-list-merge-order.sh
+++ b/t/t6001-rev-list-merge-order.sh
@@ -408,17 +408,17 @@ test_output_expect_success "max-count 10
 | b2
 EOF
 
-test_output_expect_success "max-count 10 - non merge order" 'git-rev-list --max-count=10 l5 | entag | sort' <<EOF
-a2
-a3
+test_output_expect_success "max-count 10 - non merge order" 'git-rev-list --max-count=10 l5' <<EOF
+l5
+l4
+l3
 a4
-b3
 b4
-c2
+a3
+a2
 c3
-l3
-l4
-l5
+c2
+b3
 EOF
 
 test_output_expect_success '--max-age=c3, no --merge-order' "git-rev-list --max-age=$(commit_date c3) l5" <<EOF
------------

← back to recent threads