threads / discuss / 10485

Minor inconsistency: "git tag" requires space after -m.

Subject: Minor inconsistency: "git tag" requires space after -m.

## tl;dr

3 messages between Oct 27, 2007 and Oct 27, 2007.

replies: 2people: 2as markdown or json

Sergei Organov· Oct 27, 2007, 11:55 UTC · lore

Hello,

It seems options parsing is somewhat broken in git-tag:

$ git tag -a -m"Annotated tag" annotated-tag usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>] $ git tag -a -m "Annotated tag" annotated-tag $ git --version git version 1.5.3.4

This is inconsistent with, say, "git commit", that groks -m"Message" (without space after -m) just fine.

-- 
Sergei.

Johannes Schindelin· Oct 27, 2007, 12:48 UTC · re: Sergei Organov · lore

Re: Minor inconsistency: "git tag" requires space after -m.

Hi,

On Sat, 27 Oct 2007, Sergei Organov wrote:

Show 10 quoted lines

> It seems options parsing is somewhat broken in git-tag:
> 
> $ git tag -a -m"Annotated tag" annotated-tag
> usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
> $ git tag -a -m "Annotated tag" annotated-tag
> $ git --version
> git version 1.5.3.4
> 
> This is inconsistent with, say, "git commit", that groks -m"Message"
> (without space after -m) just fine.

As it happens, we are in the middle of adding our own option parser which probably solves the issue. Can you please retest when we have that, and use it in builtin-tag?

Thanks, Dscho

Sergei Organov· Oct 27, 2007, 13:14 UTC · re: Johannes Schindelin · lore

Re: Minor inconsistency: "git tag" requires space after -m.

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 18 quoted lines

> Hi,
>
> On Sat, 27 Oct 2007, Sergei Organov wrote:
>
>> It seems options parsing is somewhat broken in git-tag:
>> 
>> $ git tag -a -m"Annotated tag" annotated-tag
>> usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
>> $ git tag -a -m "Annotated tag" annotated-tag
>> $ git --version
>> git version 1.5.3.4
>> 
>> This is inconsistent with, say, "git commit", that groks -m"Message"
>> (without space after -m) just fine.
>
> As it happens, we are in the middle of adding our own option parser which 
> probably solves the issue.  Can you please retest when we have that, and 
> use it in builtin-tag?

I'm 100% sure there will be no inconsistencies once you unify options parsing among the tools, but I won't refrain from re-testing this anyway.

-- 
Sergei.