threads / bug / 10484

[POSSIBLE BUG] 'git log' option --no-color adds bogus empty line

Subject: [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line

## tl;dr

3 messages between Oct 27, 2007 and Oct 27, 2007.

replies: 2people: 2as markdown or json

Marco Costalba· Oct 27, 2007, 09:10 UTC · lore

Form git tree:

$ git log -n 1 8d863c98b2f9b0d37 | wc
      7      28     246

$ git log --no-color -n 1 8d863c98b2f9b0d37 | wc
      8      28     247

$ git --version git version 1.5.3.2.124.g648db

What's worst is that when using --log-size option, the size is always the same (198 in this case) breaking qgit parsing when --no-color option is used.

BTW --no-color option is needed to correctly handle repositories where "diff.color = true" in the configuration as pointed out (and patched) by Yaacov Akiba Slama.

Thanks Marco

Johannes Gilger· Oct 27, 2007, 09:36 UTC · re: Marco Costalba · lore

Re: [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line

Marco Costalba wrote:

Show 10 quoted lines

> Form git tree:
> 
> $ git log -n 1 8d863c98b2f9b0d37 | wc
>       7      28     246
> 
> $ git log --no-color -n 1 8d863c98b2f9b0d37 | wc
>       8      28     247
> 
> $ git --version
> git version 1.5.3.2.124.g648db

Hi,

using git version 1.5.3.4.383.gd90a7 i can't confirm this, the two outputs are of the same length here.

Regards, Johannes

-- 
Johannes Gilger <heipei@hackvalue.de>
http://hackvalue.de/heipei/
GPG-Key: 0x42F6DE81
GPG-Fingerprint: BB49 F967 775E BB52 3A81  882C 58EE B178 42F6 DE81

Marco Costalba· Oct 27, 2007, 10:01 UTC · re: Johannes Gilger · lore

Re: [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line

On 10/27/07, Johannes Gilger <heipei@hackvalue.de> wrote:

Show 17 quoted lines

> Marco Costalba wrote:
> > Form git tree:
> >
> > $ git log -n 1 8d863c98b2f9b0d37 | wc
> >       7      28     246
> >
> > $ git log --no-color -n 1 8d863c98b2f9b0d37 | wc
> >       8      28     247
> >
> > $ git --version
> > git version 1.5.3.2.124.g648db
>
> Hi,
>
> using git version 1.5.3.4.383.gd90a7 i can't confirm this, the two
> outputs are of the same length here.
>

Yes. With the latest git everything works as expected.

Sorry fo rthe noise!

Marco