Re: [PATCH] use only the PATH for exec'ing git commands

Scott R Parish· Oct 22, 2007, 19:59 UTC · lore

Show 5 quoted lines

> Alex Reisen, Mon, Oct 22, 2007 12:01:
> > +                strbuf_addch(out, ':');
>
> Shouldn't it break MingW32 native port?
>

<snip>

> > +        if (old_path)
> > +                strbuf_addstr(&amp;new_path, old_path);
> > +        else
> > +                strbuf_addstr(&amp;new_path,

"/usr/local/bin:/usr/bin:/bin");

Show 5 quoted lines

>
> the default PATH is platform-dependent. Git is multi-platform.
> You should consider putting the path list somewhere in Makefile,
> config.mak or configure.
>

The original code was already doing both of these things (see git.c's prepend_to_path())

sRp

patchRe: [PATCH] use only the PATH for exec'ing git commands