threads / discuss / 10432

(unknown)

Subject: (unknown)

## tl;dr

3 messages between Oct 22, 2007 and Oct 23, 2007.

replies: 2people: 2as markdown or json

racin@free.fr· Oct 22, 2007, 18:16 UTC · lore

Hello,

I found the following on the development version of git.el: saving non-git-managed files in Emacs threw an error.

It is due to a simple error in the call to condition-case in a recently added function, git-update-save-file.

I attached the patch for your convenience.

Regards, Matthieu Lemerre

PS: Please Cc me when you ackwowledge; I'm not subscribed to the list.
As a matter of fact, I found the bug only because I didn't find git.el
for my distribution (debian) so I got directly from the development
version on the website.

Shawn O. Pearce· Oct 23, 2007, 04:31 UTC · re: racin@free.fr · lore

Re: git.el fails on non-git managed files

racin@free.fr wrote:

Show 7 quoted lines

> I found the following on the development version of git.el: saving
> non-git-managed files in Emacs threw an error.
> 
> It is due to a simple error in the call to condition-case in a
> recently added function, git-update-save-file.
> 
> I attached the patch for your convenience.

I'm not sure what happened, but I didn't receive a patch with
your email.  Would you mind resending it to the list?  You may
also want to file a bug with your distribution to get the Emacs
bindings included.

-- 
Shawn.

Matthieu Lemerre· Oct 23, 2007, 18:30 UTC · re: Shawn O. Pearce · lore

Re: git.el fails on non-git managed files

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 13 quoted lines

> racin@free.fr wrote:
>> I found the following on the development version of git.el: saving
>> non-git-managed files in Emacs threw an error.
>> 
>> It is due to a simple error in the call to condition-case in a
>> recently added function, git-update-save-file.
>> 
>> I attached the patch for your convenience.
>
> I'm not sure what happened, but I didn't receive a patch with
> your email.  Would you mind resending it to the list?  You may
> also want to file a bug with your distribution to get the Emacs
> bindings included.

Sure; the SMTP server of my ISP behaved weirdly yesterday and I had to use one of these webmail applications. This time it should be OK.

I'll also file a bug to debian, that's a good idea.

Matthieu Lemerre