threads / patch / 10329

patchSpeed up project listing for large working trees by limiting find depth

Subject: [PATCH] Speed up project listing for large working trees by limiting find depth

## tl;dr

One message between Oct 16, 2007 and Oct 16, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Luke Lu· Oct 16, 2007, 23:02 UTC · lore
Forgot -s last time when resubmitting the patch.

Here is a simple gitweb patch to speed up project listing on checked out repos with large trees. It was spending minutes in perl (5.8.8 macports). Reduced to a fraction of a second after the patch.

Signed-off-by: Luke Lu <git@vicaya.com>
---
 gitweb/gitweb.perl |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Show changes to gitweb/gitweb.perl +4 −0
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 3064298..a30eef9 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1509,16 +1509,20 @@ sub git_get_projects_list {
 		# remove the trailing "/"
 		$dir =~ s!/+$!!;
 		my $pfxlen = length("$dir");
+		my $pfxdepth = ($dir =~ tr!/!!);
 
 		File::Find::find({
 			follow_fast => 1, # follow symbolic links
 			follow_skip => 2, # ignore duplicates
+			no_chdir => 1, # don't chdir into every directory
 			dangling_symlinks => 0, # ignore dangling symlinks, silently
 			wanted => sub {
 				# skip project-list toplevel, if we get it.
 				return if (m!^[/.]$!);
 				# only directories can be git repositories
 				return unless (-d $_);
+				# don't traverse too deep (Find is super slow on os x)
+				return if tr!/!! - $pfxdepth > 2 && ($File::Find::prune = 1);
 
 				my $subdir = substr($File::Find::name, $pfxlen + 1);
 				# we check related file in $projectroot
-- 
1.5.3.4

← back to recent threads