threads / patch / 10253

patchfix contrib/hooks/post-receive-email hooks.recipients error message

Subject: [PATCH] fix contrib/hooks/post-receive-email hooks.recipients error message

## tl;dr

One message between Oct 11, 2007 and Oct 11, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jeff Muizelaar· Oct 11, 2007, 21:49 UTC · lore

Have the error message for missing recipients actually report the missing config variable and not a fictional one.

Show changes to contrib/hooks/post-receive-email +9 −1
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index cbbd02f..b188aa3 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -138,7 +138,15 @@ generate_email()
 
 	# Check if we've got anyone to send to
 	if [ -z "$recipients" ]; then
-		echo >&2 "*** hooks.recipients is not set so no email will be sent"
+		case "$refname_type" in
+			"annotated tag")
+				config_name="hooks.announcelist"
+				;;
+			*)
+				config_name="hooks.mailinglist"
+				;;
+		esac
+		echo >&2 "*** $config_name is not set so no email will be sent"
 		echo >&2 "*** for $refname update $oldrev->$newrev"
 		exit 0
 	fi

← back to recent threads