threads / patch / 10168

patchgit-gui: accept versions containing text annotations, like 1.5.3.mingw.1

Subject: [PATCH] git-gui: accept versions containing text annotations, like 1.5.3.mingw.1

## tl;dr

One message between Oct 6, 2007 and Oct 6, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Steffen Prohaska· Oct 6, 2007, 13:27 UTC · lore

This commit teaches git-gui to accept versions with annotations that start with text and optionally end with a dot followed by a number.

This is needed by the current versioning scheme of msysgit, which uses versions like 1.5.3.mingw.1. However, the changes is not limited to this use case. Any version of the form <numeric version>.<anytext>.<number> would be parsed and only the starting <numeric version> used for validation.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
 git-gui/git-gui.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to git-gui/git-gui.sh +1 −0
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index bb1e7f3..f671eea 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -666,6 +666,7 @@ regsub -- {-dirty$} $_git_version {} _git_version
 regsub {\.[0-9]+\.g[0-9a-f]+$} $_git_version {} _git_version
 regsub {\.rc[0-9]+$} $_git_version {} _git_version
 regsub {\.GIT$} $_git_version {} _git_version
+regsub {\.[a-zA-Z]+(\.[0-9]+)$} $_git_version {} _git_version
 
 if {![regexp {^[1-9]+(\.[0-9]+)+$} $_git_version]} {
 	catch {wm withdraw .}
-- 
1.5.3.mingw.1.106.g1610f-dirty

← back to recent threads