threads / patch / 10099

patchshortlog: remove --help option parsing

Subject: [PATCH] shortlog: remove --help option parsing

## tl;dr

2 messages between Oct 1, 2007 and Oct 1, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jonas Fonseca· Oct 1, 2007, 10:20 UTC · lore
This option is handled globally.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
 builtin-shortlog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin-shortlog.c +1 −1
diff --git a/builtin-shortlog.c b/builtin-shortlog.c
index 3fe7546..518f27f 100644
--- a/builtin-shortlog.c
+++ b/builtin-shortlog.c
@@ -264,7 +264,7 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)
 			wrap_lines = 1;
 			parse_wrap_args(argv[1], &in1, &in2, &wrap);
 		}
-		else if (!strcmp(argv[1], "-h") || !strcmp(argv[1], "--help"))
+		else if (!strcmp(argv[1], "-h"))
 			usage(shortlog_usage);
 		else
 			break;
-- 
1.5.3.2.1029.gc1d178


-- 
Jonas Fonseca
Johannes Schindelin· Oct 1, 2007, 11:42 UTC · re: Jonas Fonseca · lore

Re: [PATCH] shortlog: remove --help option parsing

Hi,
On Mon, 1 Oct 2007, Jonas Fonseca wrote:
> -		else if (!strcmp(argv[1], "-h") || !strcmp(argv[1], "--help"))
> +		else if (!strcmp(argv[1], "-h"))
I see that this is my fault.

Thanks, Dscho

← back to recent threads