threads / rfc / 10073

[RFC] patch series to sketch a less verbose and frightening output

Subject: [RFC] patch series to sketch a less verbose and frightening output

## tl;dr

4 messages between Sep 29, 2007 and Sep 29, 2007.

replies: 3people: 2as markdown or json

Pierre Habouzit· Sep 29, 2007, 10:45 UTC · lore
  Follow 4 patches that rework progress.c a bit so that one stage only
takes one line of output with a progress bar.
  Some of the patch fix (IMHO) pointless lines to print on screen (even
for debugging purposes).
  With those patches, running git gc looks like:
    $ git gc
    Counting objects    : 10095
    Deltifying objects  : [===================================================] 100%
    Writing objects     : [==========================>                        ] 50%
    [...]
    Counting objects    : 10095
    Deltifying objects  : [===================================================] 100%
    Writing objects     : [===================================================] 100%
    Pruning objects     : [===================================================] 100%

I don't believe those patches are 100% okay yet, because it doesn't plays that nice during a clone (it's not horribly broken, merely surprising). But it sketches what it could look like.

Pierre Habouzit· Sep 29, 2007, 10:49 UTC · re: Pierre Habouzit · lore

Re: [RFC] patch series to sketch a less verbose and frightening output

On Sat, Sep 29, 2007 at 10:45:54AM +0000, Pierre Habouzit wrote:
Show 23 quoted lines
>   Follow 4 patches that rework progress.c a bit so that one stage only
> takes one line of output with a progress bar.
> 
>   Some of the patch fix (IMHO) pointless lines to print on screen (even
> for debugging purposes).
> 
>   With those patches, running git gc looks like:
> 
>     $ git gc
>     Counting objects    : 10095
>     Deltifying objects  : [===================================================] 100%
>     Writing objects     : [==========================>                        ] 50%
> 
>     [...]
> 
>     Counting objects    : 10095
>     Deltifying objects  : [===================================================] 100%
>     Writing objects     : [===================================================] 100%
>     Pruning objects     : [===================================================] 100%
> 
> I don't believe those patches are 100% okay yet, because it doesn't
> plays that nice during a clone (it's not horribly broken, merely
> surprising). But it sketches what it could look like.
  Okay, sorry this was supposed to answer to
<20070929090121.GA4216@artemis.corp>
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Nicolas Pitre· Sep 29, 2007, 14:33 UTC · lore

Re: [PATCH 1/4] Rework progress module so that it uses less screen lines, with progress bars.

On Sat, 29 Sep 2007, Pierre Habouzit wrote:
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
NAK.

I don't mind the progress bar, but please don't supress the printing of the number of objects. This is the only indication we have to guesstimate the time needed for given operation.

Nicolas
Pierre Habouzit· Sep 29, 2007, 16:07 UTC · re: Nicolas Pitre · lore

Re: [PATCH 1/4] Rework progress module so that it uses less screen lines, with progress bars.

On Sat, Sep 29, 2007 at 02:33:44PM +0000, Nicolas Pitre wrote:
Show 9 quoted lines
> On Sat, 29 Sep 2007, Pierre Habouzit wrote:
> 
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> 
> NAK.
> 
> I don't mind the progress bar, but please don't supress the printing of 
> the number of objects.  This is the only indication we have to 
> guesstimate the time needed for given operation.
  As said, I don't intend this series to be integrated as is, it's just
a basis for some discussion :)
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

← back to recent threads