threads / patch / 10059

patchpost-receive-hook: Remove the From field from the generated email header so that the pusher's name is used

Subject: [PATCH] post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used

## tl;dr

One message between Sep 28, 2007 and Sep 28, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Andy Parkins· Sep 28, 2007, 14:24 UTC · lore

Using the name of the committer of the revision at the tip of the updated ref is not sensible. That information is available in the email itself should it be wanted, and by supplying a "From", we were effectively hiding the person who performed the push - which is useful information in itself.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 contrib/hooks/post-receive-email |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Show changes to contrib/hooks/post-receive-email +0 −1
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 1f88099..cbbd02f 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -177,7 +177,6 @@ generate_email_header()
 	# --- Email (all stdout will be the email)
 	# Generate header
 	cat <<-EOF
-	From: $committer
 	To: $recipients
 	Subject: ${EMAILPREFIX}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
 	X-Git-Refname: $refname
-- 
1.5.3.2.105.gf47f2-dirty

← back to recent threads