# grafts not appearing in manual pages 4 messages from 2007-09-26 to 2007-09-27. Participants: Mike Hommey, J. Bruce Fields, Johannes Sixt, Junio C Hamano. Thread: https://gitlist.dev/t/10033 ## Mike Hommey, 2007-09-26 20:24 Subject: grafts not appearing in manual pages Message-ID: <20070926202441.GA31848@glandium.org> URL: https://gitlist.dev/e/20070926202441.GA31848%40glandium.org ``` Hi, The only occurrence of grafts in the manual pages is in the git-filter-branch one. I somehow feel this is wrong not to see it described more "formally" in the manual pages. I wouldn't mind writing a small something, except I have no idea what would be the most appropriate place to talk about it... Does anyone have such an idea ? Cheers, Mike ``` ## J. Bruce Fields, 2007-09-26 21:01 Subject: Re: grafts not appearing in manual pages Message-ID: <20070926210102.GF26099@fieldses.org> URL: https://gitlist.dev/e/20070926210102.GF26099%40fieldses.org In-Reply-To: <20070926202441.GA31848@glandium.org> ``` On Wed, Sep 26, 2007 at 10:24:41PM +0200, Mike Hommey wrote: > Hi, > > The only occurrence of grafts in the manual pages is in the > git-filter-branch one. I somehow feel this is wrong not to see it > described more "formally" in the manual pages. > > I wouldn't mind writing a small something, except I have no idea what > would be the most appropriate place to talk about it... Does anyone have > such an idea ? It could go in Documentation/user-manual.txt, but I don't know where. Maybe at the end of the git-concepts chapter? Patches welcomed. I guess what's needed (and currently missing) is an overview explaining what they're actually for, plus some basic setup instructions. And/or maybe a section 5 manual page documenting the format of the "grafts" file? Maybe that's overkill. There's a paragraph in Documentation/repository-layout.txt. Maybe we need to make it easier to find that file. --b. ``` ## Johannes Sixt, 2007-09-27 06:22 Subject: Re: grafts not appearing in manual pages Message-ID: <46FB4C23.8010400@viscovery.net> URL: https://gitlist.dev/e/46FB4C23.8010400%40viscovery.net In-Reply-To: <20070926210102.GF26099@fieldses.org> ``` J. Bruce Fields schrieb: > On Wed, Sep 26, 2007 at 10:24:41PM +0200, Mike Hommey wrote: >> Hi, >> >> The only occurrence of grafts in the manual pages is in the >> git-filter-branch one. I somehow feel this is wrong not to see it >> described more "formally" in the manual pages. >> >> I wouldn't mind writing a small something, except I have no idea what >> would be the most appropriate place to talk about it... Does anyone have >> such an idea ? > > It could go in Documentation/user-manual.txt, but I don't know where. IMHO grafts should not be made known to a wide audience until send-pack, pack-objects, and prune are fixed so that you cannot corrupt your repository when there are grafts. See http://thread.gmane.org/gmane.comp.version-control.git/37744 in particular http://article.gmane.org/gmane.comp.version-control.git/37866 on a sketch how to fix the issues. -- Hannes ``` ## Junio C Hamano, 2007-09-27 07:25 Subject: Re: grafts not appearing in manual pages Message-ID: <7vmyv8wowc.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmyv8wowc.fsf%40gitster.siamese.dyndns.org In-Reply-To: <46FB4C23.8010400@viscovery.net> ``` Johannes Sixt writes: > J. Bruce Fields schrieb: > ... >> It could go in Documentation/user-manual.txt, but I don't know where. > > IMHO grafts should not be made known to a wide audience until > send-pack, pack-objects, and prune are fixed so that you cannot > corrupt your repository when there are grafts. I mildly have to disagree. Documenting the current semantics (in short, "grafts are strictly local matter") and the implications is important. Here are some of the points you would want to mention: - if you graft, prune and fsck will honor that fake ancestry, - if you _add_ parent by grafting you will not lose the history that is otherwise disconnected, but on the other hand, once having pruned that way and you remove that graft, prune will discard that discontiguous history away. - if you _hide_ parent by grafting, you will be able to lose the hidden subbranch away, but you will get complaints from fsck if you remove that graft after pruning your history. - if you try to fetch/push across repositories with different notion of ancestry (because of different grafts), things can break in expected ways (and you can keep both halves ;-). For example, if the sending side has extra parents to a commit compared to the receiving side, and if the receiving side claims to have that commit, objects reachable from the extra parents might be missing from the reciving end but the sender will not be able to notice. > See http://thread.gmane.org/gmane.comp.version-control.git/37744 > in particular http://article.gmane.org/gmane.comp.version-control.git/37866 > on a sketch how to fix the issues. IIRC, there discussions were more about what the issues are and what the potential semantics could be. First the desired semantics need to be defined. ```