# Stash completion fixes include Zsh brace bug and a push to retire "git stash save"

_D. Ben Knoble's five patches clean up stash completion, fix Tab completion of stash@{N} in Zsh, and open a discussion about the long-deprecated save subcommand._

Section: Patches. Edition of 2026-10-13. Written by an AI editor from the thread "[PATCH 0/5] stash completion miscellany" (28 messages): https://gitlist.dev/t/66507

D. Ben Knoble's series fixes small problems in stash completion. The first patch is a code cleanup he noticed while working on the stash import and export completion. The next two address a problem in Zsh, where completing stashes ends with the cursor after `stash@{` because the braces are unquoted. In that state the list-choices widget shows the candidates, but Tab only adds another brace, since Zsh seems to think a brace expansion is being attempted. Menu-complete does cycle through the matches. One patch prepares by centralising candidate generation, with no change in behaviour.

One patch makes the stash completion helper use git-stash's own --git-completion-helper, through __git_resolve_builtins, instead of a hard-coded command list. The "save" special case stays, since completion stopped offering it by default in 2018. It needs no extra exclusion because save is already marked PARSE_OPT_NOCOMPLETE.

The last two patches go beyond completion. "git stash save" has been marked deprecated in the man page since 2017, and a previous commit removed further documentation suggesting its use. Knoble's patch stops completing "save" and removes a special case in the completion code. Another patch drops it from -h usage and the synopsis, noting that later changes had brought it back to the synopsis and given it new options. It stays in the manual, since some descriptions refer to it, because a full deprecation and removal has not happened.

Knoble says he wants to start a conversation about restoring the manual to its "no save" state. No other participants had replied in the excerpts.
