Aniket Gupta's v3 has three patches: add relative_url_gently(), stop relative_url() from showing credentials when it fails, and make bundle-uri skip an unresolvable relative URI rather than die. Today one such entry makes the whole clone fail.

Derrick Stolee first worried about the behavior change. He then noted that patch 3 removes a TODO he himself added in ebc39479558 (bundle-uri: allow relative URLs in bundle lists, 2022-12-22), and withdrew his concerns. He said some users could depend on the old behavior but called that unlikely to matter. As a follow-up he suggested a way to re-enable the die() for users who would rather fail than spend time on an incomplete bundle advertisement and a costly fetch from the remote.

Gupta acknowledged an inaccuracy in his patch 3 commit message. It says the clone carries on with the other bundles, but the list is only used up to the bad entry (not at all for a list given to --bundle-uri), after which the clone fetches from the remote.

The credential patch drew more resistance. Stolee said users asked Git to operate on the URL, so they should know which string caused the problem, and that systems storing logs already have to handle such strings. Gupta replied that his test showed a password in the remote URL appears as-is in the "failed to download bundle from URI" warning, so the patch covers only one message. He said it is easy to drop.

Junio C Hamano also questioned how careful systems can be without knowing what the strings are. He listed existing anonymize_url() uses and suggested the patch may protect against an issue that does not arise in practice. Whether the credential patch stays is unresolved.