From: Justin Tobler <jltobler@gmail.com>
Date: Mon, 30 Jun 2025 02:56:05 GMT
Subject: Re: [PATCH v5 08/17] odb: get rid of `the_repository` when handling alternates
Message-ID: <zsrwwg5mhxx7xk53i7czza5sageivnm2hxj5nlvunpe4gzrrjq@n5ne6qwovyom>
In-Reply-To: <20250605-pks-object-store-wo-the-repository-v5-8-779d1c28774b@pks.im>

On 25/06/05 08:46AM, Patrick Steinhardt wrote:
> The functions to manage alternates all depend on `the_repository`.
> Refactor them to accept an object database as parameter and adjusting

s/parameter and adjusting/a parameter and adjust/

> all callers. The functions are renamed accordingly.
> 
> Note that right now the situation is still somewhat weird because we end
> up using the path provided by the object store's repository anyway. This
> will be adapted over time though so that we instead store the path to
> the primary object directory in the object database itself.

Just to clarify, are we walking about the path to the alternate odb? I'm
not quite sure I follow.

The renames and refactors in this patch look good.

-Justin

> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>