From: Justin Tobler <jltobler@gmail.com>
Date: Wed, 10 Apr 2024 21:49:21 GMT
Subject: Re: [PATCH 0/2] t0610: fix umask tests
Message-ID: <zmr3qstsa3egnt7qi3pvaonltk4aoqr3x3vzch7esqjj7vuyj7@vbxldlnl6h4k>
In-Reply-To: <cover.1712656576.git.ps@pks.im>

On 24/04/09 11:57AM, Patrick Steinhardt wrote:
> Hi,
> 
> these patches address the issue reported by Junio where running t0610
> with an umask of 0027 breaks some tests. The root cause of this is quite
> simple: we executed git-pack-refs(1) outside of the shell that had the
> modified umask, and thus we ran tests with the umask of the host shell
> by accident.
> 
> The series fixes this issue and extends the tests to exercise more
> umasks than just 002 and 022, which would have caught the issue earlier.
> 
> Patrick
> 
> Patrick Steinhardt (2):
>   t0610: make `--shared=` tests reusable
>   t0610: execute git-pack-refs(1) with specified umask
> 
>  t/t0610-reftable-basics.sh | 67 ++++++++++++++++++++++----------------
>  1 file changed, 39 insertions(+), 28 deletions(-)
> 
> -- 
> 2.44.GIT
> 

Nice fix! I like how the tests were made more extensible too. This looks
good to me :)

-Justin