From: Brandon Casey Date: Fri, 27 Feb 2009 15:47:49 GMT Subject: Re: serious problem with `git format-patch' & `git am' Message-ID: In-Reply-To: <7viqmwpr2x.fsf@gitster.siamese.dyndns.org> Junio, I think you are the author of git-am.sh. What does this line do? git-am.sh line 375: case "$keep_subject" in -k) SUBJECT="[PATCH] $SUBJECT" ;; esac It appears to do nothing. It has existed since the beginning of git-am.sh, and there has never been another reference to $keep_subject in this script. Is it possible that $keep_subject is supposed to be $keep? -brandon