From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 26 Apr 2010 06:30:55 GMT
Subject: Re: [PATCH 1/3] pretty: add conditional %C?colorname placeholders
Message-ID: <z2y81b0412b1004252330m189e68bcv19d7d1cb988820b6@mail.gmail.com>
In-Reply-To: <1272210175-20484-2-git-send-email-wmpalmer@gmail.com>

On Sun, Apr 25, 2010 at 17:42, Will Palmer <wmpalmer@gmail.com> wrote:
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index 1686a54..53eb903 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -132,6 +132,7 @@ The placeholders are:
>  - '%Cblue': switch color to blue
>  - '%Creset': reset color
>  - '%C(...)': color specification, as described in color.branch.* config option
> +- '%C?...: switch to specified color, if relevant color.* config option specifies that color is ok

You missed the closing quote character. Besides, how do you think to
distinguish between "%C?diff.color" and "%C?diff.colorcontinuation text"?
The "%C(...)" has a placeholde termination rule (the closing bracket), yours
does not seem to have one (unless something is missing in the documentation).

Ah... I see. Definitely something missing. The spec should be: '%C?(...)'.