From: Justin Tobler <jltobler@gmail.com>
Date: Fri, 24 May 2024 21:33:51 GMT
Subject: Re: [PATCH v2 1/9] setup: unset ref storage when reinitializing repository version
Message-ID: <yl4wqgtcfapjxuknb57sevnoi4jbcjnp3l6vqa7criqv2upq5p@x4hm33ymxukk>
In-Reply-To: <8b11127daf4c1d06eed4a0c83dd3dc981ffdc728.1716545235.git.ps@pks.im>

On 24/05/24 12:14PM, Patrick Steinhardt wrote:
> When reinitializing a repository's version we may end up unsetting the
> hash algorithm when it matches the default hash algorithm. If we didn't
> do that then the previously configured value might remain intact.
> 
> While the same issue exists for the ref storage extension, we don't do
> this here. This has been fine for most of the part because it is not
> supported to re-initialize a repository with a different ref storage
> format anyway. We're about to introduce a new command to migrate ref
> storages though, so this is about to become an issue there.

Ah, so this would be important in the context of migrating a repository
from "reftable" to "files".

> Prepare for this and unset the ref storage format when reinitializing a
> repoistory with the "files" format.

s/repoistory/repository/

-Justin