From: Justin Tobler <jltobler@gmail.com>
Date: Wed, 22 Oct 2025 13:50:17 GMT
Subject: Re: [PATCH v6 4/7] builtin/repo: introduce structure subcommand
Message-ID: <xnxnqvnz22n5tognru676vczqseuc2zpyjdkffz4svji7glkw3@loo2xq33wueh>
In-Reply-To: <aPhlLbsOFxeOv5KZ@pks.im>

On 25/10/22 07:01AM, Patrick Steinhardt wrote:
> On Tue, Oct 21, 2025 at 01:25:58PM -0500, Justin Tobler wrote:
> > +static int count_references(const char *refname,
> > +			    const char *referent UNUSED,
> > +			    const struct object_id *oid UNUSED,
> > +			    int flags UNUSED, void *cb_data)
> 
> Tiniest nit, not worth a reroll: we tend to use these callbacks in
> singular, as you end up doing the thing for one specific entity.

Good to know and makes sense. I'll hold off from sending another version
for now. I can also probably adjust as part of my planned followup
series.

> Other than that this series looks good to me now and is ready to be
> merged from my point of view. Thanks!

Thanks for the review.

-Justin