From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Oct 2013 00:52:49 GMT
Subject: Re: [PATCH v2 1/7] gitk: support -G option from the command line
Message-ID: <xmqqzjprd1ge.fsf@gitster.dls.corp.google.com>
In-Reply-To: <72ba9e0cd862a2fb014d0633802f9afbb0bea27d.1383031141.git.tr@thomasrast.ch>

Thomas Rast <tr@thomasrast.ch> writes:

> From: Thomas Rast <trast@inf.ethz.ch>
>
> The -G option's usage is exactly analogous to that of -S, so
> supporting it is easy.
>
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
> ---
>  gitk-git/gitk | 2 +-

You CC'ed Paul, which is absolutely the right thing to do, but
please make patches against his tree, which does not have gitk-git/
directory at the top-level.

I think the patch itself makes sense.

Thanks.

>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 5cd00d8..0e95814 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -227,7 +227,7 @@ proc parseviewargs {n arglist} {
>  	    "--until=*" - "--before=*" - "--max-age=*" - "--min-age=*" -
>  	    "--author=*" - "--committer=*" - "--grep=*" - "-[iE]" -
>  	    "--remove-empty" - "--first-parent" - "--cherry-pick" -
> -	    "-S*" - "--pickaxe-all" - "--pickaxe-regex" -
> +	    "-S*" - "-G*" - "--pickaxe-all" - "--pickaxe-regex" -
>  	    "--simplify-by-decoration" {
>  		# These mean that we get a subset of the commits
>  		set filtered 1