From: Junio C Hamano Date: Tue, 04 Feb 2014 21:03:41 GMT Subject: Re: [PATCH] blame.c: prepare_lines should not call xrealloc for every line Message-ID: In-Reply-To: <87ha8ewqfv.fsf@fencepost.gnu.org> David Kastrup writes: > Anybody know offhand what I should be including here? It looks like Git > has some fallback definitions of its own, so it's probably not just > I should include? In general, no *.c files outside the compatibility layer should include anything "#include ", as there seem to be finicky systems that care about order of inclusion and feature macro definitions, all of which are meant to be handled by including git-compat-util.h as the very first thing.