From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Apr 2014 17:26:12 GMT
Subject: Re: [PATCH v2] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR
Message-ID: <xmqqzjj2g24r.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CABPQNSZVFWhP+oTYpU2HeenJXwMsDNQGegwYZVb=bZ2+BRz3-w@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

> On Wed, Apr 30, 2014 at 5:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I think something along the lines of
>>
>>         ifdef CURLDIR
>>                 CURL_LIBCURL =
>>         else
>>                 CURL_CONFIG = curl-config
>>                 CURL_LIBCURL := $(shell sh -c '$(CURL_CONFIG) --libs' 2>/dev/null)
>>         fi
>>
>> may be the right way to write this?
>>
>> Note that $(shell $(CURL_CONFIG) --libs) when CURL_CONFIG is empty
>> would barf when $(CURL_CONFIG) expands to an empty string.
>
> There's still the fact that msysGit does *not* need CURLDIR, but
> doesn't have curl-config either. So I think this one will also
> complain for us.

Even with 2>/dev/null?