From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 18 Jul 2014 17:01:57 GMT
Subject: Re: [PATCH v10 4/4] test-config: add tests for the config_set API
Message-ID: <xmqqzjg6mwhm.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1405675142-20300-5-git-send-email-tanayabh@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

> +test_expect_success 'proper error on non-existant files' '
> +	echo "Error (-1) reading configuration file non-existant-file." >expect &&

s/tant/tent/ perhaps?
cf. http://en.wiktionary.org/wiki/non-existant

> +test_expect_success 'proper error on non-accessible files' '
> +	chmod -r .git/config &&
> +	test_when_finished "chmod +r .git/config" &&
> +	echo "Error (-1) reading configuration file .git/config." >expect &&
> +	test_expect_code 2 test-config configset_get_value foo.bar .git/config 2>actual &&
> +	test_cmp expect actual
> +'

Doesn't this one need some prerequisite?