From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 22 Jul 2014 21:46:28 GMT
Subject: Re: [PATCH 12/12] refs.c: fix handling of badly named refs
Message-ID: <xmqqzjg1dq2z.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAL=YDWnTNKGW3AAr7twZ44KUb1Pxu0kms5Lt_3-4LBYGQw2+PQ@mail.gmail.com>

Ronnie Sahlberg <sahlberg@google.com> writes:

> I don't think we need to do that.
> That would imply that we would need to be able to also allow reading
> the content of a badly named ref.
> Currently a badly named ref can not be accessed by any function except
>  git branch -D <badlynamedref> which contains the special flag that
> allows locking it eventhough the ref has an illegal name.
>
> So no one else should be able to read or modify the ref at all.

OK.

> I think it is sufficient for this case to just have the semantics
> "just delete it, I don't care what it used to point to." for this
> special case  git branch -D <badrefname>
> so therefore since it is not the content of the ref but the name of
> the ref itself we have a problem with I don't think we need to read
> the old value or verify it.