From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Jan 2015 17:52:18 GMT
Subject: Re: [PATCH 00/10] mark private symbols static
Message-ID: <xmqqzj9k6iel.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150115071827.GG11028@peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Jan 14, 2015 at 03:40:45PM -0800, Junio C Hamano wrote:
>
>> Here are a handful of patches to make symbols that are only used
>> within a .c file as static.  This is not the kind of changes we
>> would want to do in the pre-release freeze period, and it is just
>> for reference.  I may later come back to them after 2.3 final is
>> tagged.
>
> I commented specifically on the ones that are in areas I touch a lot,
> but all of them look fine to me.

Thanks for reviews.

The primary reason I sent out this series was to show the reasoning
in 00/10 to decide what *not* to touch, by the way, to send a signal
to those who may want to throw unnecessary churn at the codebase, by
the way ;-)