From: Junio C Hamano Date: Wed, 16 Sep 2015 22:34:32 GMT Subject: Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref Message-ID: In-Reply-To: <1442441194-5506-2-git-send-email-jacob.e.keller@intel.com> Jacob Keller writes: > From: Jacob Keller > > The documentation for --refs says that it will treat unqualified refs as > under refs/notes. Current behavior is to prefix refs/notes to all > strings that do not start with refs/notes or notes/, resulting in > performing actions on refs such as "refs/notes/refs/foo/bar" instead of > attempting to perform actions on "refs/foo/bar". That actually sounds like a sensible thing to do, if you replace 'foo' with 'heads', for example, i.e. refs/notes/refs/heads/bar is a notes about commits reachable from the branch whose name is 'bar'. So given "refs/heads/bar", which is unqualified in the context of talking about references that hold notes trees, the current behaviour to turn it into "refs/notes/refs/heads/bar" is very sensible, I would think.