From: Junio C Hamano Date: Tue, 10 May 2016 17:38:03 GMT Subject: Re: [PATCH v8 3/3] submodule: ensure that -c http.extraheader is heeded Message-ID: In-Reply-To: <1b3d7bde2b92da7722ae46a2f76ccedf532ce35e.1462863934.git.johannes.schindelin@gmx.de> Johannes Schindelin writes: > To support this developer's use case of allowing build agents token-based > access to private repositories, we introduced the http.extraheader > feature, allowing extra HTTP headers to be sent along with every HTTP > request. > > This patch verifies that we can configure these extra HTTP headers via the > command-line for use with `git submodule update`, too. Example: git -c > http.extraheader="Secret: Sauce" submodule update --init > > Signed-off-by: Johannes Schindelin > --- Applying this directly on top of the other two fails, and when merged with jk/submodule-c-credential, the test passes. Which is exactly what we expect to see. Nice. I'll merge jk/submodule-c-credential into js/http-custom-headers that already has 1 & 2, and then apply this. An alternative would be to hold this and wait until both jk/submodule-c-credential and js/http-custom-headers with 1 & 2 graduates and then apply this, which is a lot inferior option. Thanks. > t/t5551-http-fetch-smart.sh | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh > index 43b257e..2f375eb 100755 > --- a/t/t5551-http-fetch-smart.sh > +++ b/t/t5551-http-fetch-smart.sh > @@ -287,7 +287,16 @@ test_expect_success 'custom http headers' ' > fetch "$HTTPD_URL/smart_headers/repo.git" && > git -c http.extraheader="x-magic-one: abra" \ > -c http.extraheader="x-magic-two: cadabra" \ > - fetch "$HTTPD_URL/smart_headers/repo.git" > + fetch "$HTTPD_URL/smart_headers/repo.git" && > + git update-index --add --cacheinfo 160000,$(git rev-parse HEAD),sub && > + git config -f .gitmodules submodule.sub.path sub && > + git config -f .gitmodules submodule.sub.url \ > + "$HTTPD_URL/smart_headers/repo.git" && > + git submodule init sub && > + test_must_fail git submodule update sub && > + git -c http.extraheader="x-magic-one: abra" \ > + -c http.extraheader="x-magic-two: cadabra" \ > + submodule update sub > ' > > stop_httpd