From: Junio C Hamano Date: Fri, 03 Jun 2016 23:42:37 GMT Subject: Re: [PATCH 1/3] pretty: support "mboxrd" output format Message-ID: In-Reply-To: Eric Sunshine writes: >> static int is_mboxrd_from(const char *line) { >> return starts_with(line + strspn(line, ">"), "From "); >> } >> >> is sufficiently high-level that no longer is scary, hopefully? > > That's nice and concise but unfortunately not useful for this case > where we must respect the logical end-of-line (within the larger > buffer), represented by line+linelen. Hmph, none of ">", "F", "r", "o", "m", or " " is "\n"; would eol still be an issue?