From: Junio C Hamano Date: Fri, 19 Aug 2016 19:49:38 GMT Subject: Re: [PATCH v8 3/8] diff: prepare for additional submodule formats Message-ID: In-Reply-To: <20160819000031.24854-4-jacob.e.keller@intel.com> Jacob Keller writes: > +enum diff_submodule_format { > + DIFF_SUBMODULE_SHORT = 0, > + DIFF_SUBMODULE_LOG, > +}; Unlike definition of an array elements, enum {} did not allow trailing comma until recent versions of C, and we avoid it. No need to resend only to fix this, as I have locally amended it. Thanks.