From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Jan 2017 23:20:17 GMT
Subject: Re: [PATCH 0/5] introduce SWAP macro
Message-ID: <xmqqzii8rv7y.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <8ef4c833-45bd-6831-0683-6d01f30aa518@web.de>

René Scharfe <l.s.r@web.de> writes:

> Exchanging the value of two variables requires declaring a temporary
> variable and repeating their names.  The swap macro in apply.c
> simplifies this for its callers without changing the compiled binary.
> Polish this macro and export it, then use it throughout the code to
> reduce repetition and hide the declaration of temporary variables.

All looked reasonable (modulo "swap tree2 and tree1???" ordering).
Also the object-id ones looked good.

Thanks.