From: Junio C Hamano Date: Fri, 13 Oct 2017 03:37:57 GMT Subject: Re: [PATCH 1/2] color: downgrade "always" to "auto" only for on-disk configuration Message-ID: In-Reply-To: <20171013014721.d4vesqv4v5j7tmk2@sigill.intra.peff.net> Jeff King writes: > OK. For the record, I'm not against scrapping this whole thing and > trying to rollback to your "plumbing never looks at color.ui" proposal. > It's quite late in the -rc cycle to do that, but there's nothing that > says we can't bump the release date if that's what we need to do to get > it right. I think that it is too late, regardless of our release cycle. "Plumbing never looks at color.ui" implies that "plumbing must not get color.ui=auto from 4c7f1819", but given that 4c7f1819 is from 2013, I'd be surprised if we stopped coloring output from plumbing without getting any complaints from third-party script writers.