From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 19 Mar 2018 16:19:42 GMT
Subject: Re: [PATCH v6 09/11] pack-objects: shrink size field in struct object_entry
Message-ID: <xmqqzi34vy01.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180318142526.9378-10-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> +static inline int oe_fits_in_32bits(unsigned long limit)
> +{
> +	uint32_t truncated_limit = (uint32_t)limit;
> +
> +	return limit == truncated_limit;
> +}

I do not think it is worth a reroll (there only are a few
callsites), but the above has nothing to do with "oe" fitting
anything (it is about "limit").  Do you mind if I did this instead?

	static inline int fits_in_32bits(unsigned long size)

... or other suggestions, perhaps?