From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 12 Jul 2018 18:50:29 GMT
Subject: Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains
Message-ID: <xmqqzhywwaoa.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cRZmx5_3-a0C=WdWnmcrh4J_1YHY_0FmXZh5LzcDq+6Uw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Thu, Jul 12, 2018 at 2:35 PM Junio C Hamano <gitster@pobox.com> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> Oops, sent before completing the message.
>>
>>         For that to happen, we need a sign-off ;-)
>>
>> I guess this one would have been caught with the "sed script on
>> subshell" linter that does not execute?
>
> Yes, this is correctly caught when the prerequisite is met.
>
>> -- >8 --
>> Subject: t5608: fix broken &&-chain
>>
>> This is inside a loop that is run inside a subshell, in a test that
>> is protected with CLONE_2GB prerequisite, one or more which is quite
>> likely reason why it wasn't caught durin the previous clean-up.
>
> s/durin/during/
>
> The exact reason is that the prerequisite was not met (indeed, I
> wasn't even aware of that prerequisite), so the commit message can be
> more direct:
>
>     This was missed by the previous clean-ups due to an unmet
>     CLONE_2GB prerequisite.
>
> Thanks for saving a round-trip.
>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>

There still need a sign-off, so ... ;-)